Skip to content

PHPLIB-1680: Remove obsolete wire version checks for MongoDB 4.2 #1695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: v2.x
Choose a base branch
from
Open

PHPLIB-1680: Remove obsolete wire version checks for MongoDB 4.2 #1695

wants to merge 1 commit into from
+6 −42

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented May 20, 2025

@jmikola
Copy link
Member

jmikola commented Jul 21, 2025

@alcaeus: Is there more to do here?

@alcaeus alcaeus marked this pull request as ready for review July 22, 2025 06:49
@alcaeus alcaeus requested a review from a team as a code owner July 22, 2025 06:49
@alcaeus alcaeus requested a review from paulinevos July 22, 2025 06:49
@alcaeus
Copy link
Member Author

alcaeus commented Jul 22, 2025

@jmikola no - I had merely forgotten to update this move this PR into review after doing the 2.1.0 update for libmongoc. We were waiting for that as that is the libmongoc version that actually drops support for 4.2 and people could still connect to 4.2 servers before then.

@alcaeus alcaeus force-pushed the phplib-1680-drop-version-checks-4.2 branch from ecfc3f9 to 22fb247 Compare July 22, 2025 06:51
@alcaeus alcaeus requested review from jmikola and removed request for paulinevos July 22, 2025 06:51
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.56%. Comparing base (6b1c3cc) to head (22fb247).

Additional details and impacted files 
@@             Coverage Diff              @@
##               v2.x    #1695      +/-   ##
============================================
+ Coverage     87.54%   87.56%   +0.01%     
+ Complexity     3182     3172      -10     
============================================
  Files           423      423              
  Lines          6336     6329       -7     
============================================
- Hits           5547     5542       -5     
+ Misses          789      787       -2
Flag Coverage Δ
6.0-replica_set 85.66% <100.00%> (+0.01%) ⬆️
6.0-server 81.67% <100.00%> (+0.01%) ⬆️
6.0-sharded_cluster 85.25% <100.00%> (+0.01%) ⬆️
8.0-replica_set 87.48% <100.00%> (+0.01%) ⬆️
8.0-server 82.55% <100.00%> (+0.01%) ⬆️
8.0-sharded_cluster 87.15% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikola jmikola Awaiting requested review from jmikola

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alcaeus @jmikola @codecov-commenter